thin-edge.io icon indicating copy to clipboard operation
thin-edge.io copied to clipboard

Published 20 hours ago • verified publisher icon thin-edge

Make systemd watchdog backend only build for linux

Open matthiasbeyer opened this issue 1 year ago • 2 comments

Following the discussion in #1278 and as suggested by @albinsuresh:

This patch ensures that the systemd watchdog backend is only used when building for linux.

Right now, there is no other watchdog implementation. Thus, there is a "dummy_watchdog" module introduced that does nothing. This might be removed and replaced by something specific, if we ever build thin-edge.io for other targets, such as Apple, FreeBSD or others.

I'm going to request review by multiple people, so everyone knows about this and has the chance of saying something if this is not the right approach (because we might possibly need more like this in the future).

matthiasbeyer avatar Aug 03 '22 07:08 matthiasbeyer

Liked the simplicity of this approach. But, let's merge it only after getting a wider consensus.

albinsuresh avatar Aug 08 '22 06:08 albinsuresh

Are all target platforms tested on CI?

I guess only default linux (x86_64) and armv7 linux. I guess that's all.

matthiasbeyer avatar Aug 13 '22 07:08 matthiasbeyer

Rebased and squashed.

matthiasbeyer avatar Aug 16 '22 09:08 matthiasbeyer