thin-edge.io icon indicating copy to clipboard operation
thin-edge.io copied to clipboard

Update rustc: 1.58.1 -> 1.63.0

Open matthiasbeyer opened this issue 1 year ago • 1 comments

Proposed changes

In #1279 we had a brief discussion whether to update rustc in our CI or not.

IMO there's no reason why we shouldn't, so here goes a PR to update rustc in all workflows.

Checklist

  • [x] I have read the CONTRIBUTING doc
  • [x] I have signed the CLA (in all commits with git commit -s)
  • [x] I ran cargo fmt as mentioned in CODING_GUIDELINES
  • [x] I used cargo clippy as mentioned in CODING_GUIDELINES
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added necessary documentation (if appropriate)

matthiasbeyer avatar Jul 26 '22 07:07 matthiasbeyer

Heh, this obviously has to go in after #1279 :laughing:

matthiasbeyer avatar Jul 26 '22 08:07 matthiasbeyer

I guess this one also depends on #1349

matthiasbeyer avatar Aug 18 '22 14:08 matthiasbeyer

So it seems that before 1.63.0 the fix from #1310 does not work, and after 1.63.0 the fix from #1310 is required.

So I picked the patch from #1310 to this PR and am going to close #1310 in favour of this PR.

matthiasbeyer avatar Aug 18 '22 14:08 matthiasbeyer