thin-edge.io icon indicating copy to clipboard operation
thin-edge.io copied to clipboard

docker/docker-compos images are always pruned

Open TheNeikos opened this issue 2 years ago • 2 comments

Describe the bug

In the lifecycle of the docker plugin, the finalize step calls 'docker image prune --all --force' which would unconditionally remove all unused docker images whenever the docker plugin is asked to 'install/remove' something.

Expected behavior

ThinEdge should not remove things it was not asked about.


The same is true for the docker-compose plugin.

TheNeikos avatar Apr 04 '22 09:04 TheNeikos

I agree that pruning all the images on install/remove is a cause of bad surprises.

I also wonder if this is the right place for these Docker and Docker Compose plugins. They are examples after all.

didier-wenzek avatar Apr 11 '22 15:04 didier-wenzek

AC

  • Fix the reported issue.
  • Then move docker and docker-compose plugins to the example repo.
  • Update tests using docker and docker-compose plugins from the example repo.

rina23q avatar Apr 12 '22 10:04 rina23q

A new sm-plugin has already been created to support container management, see the tedge-container-plugin repository.

So all that is left is to remove the docker and docker-compose plugins from the project.

reubenmiller avatar Jun 06 '23 11:06 reubenmiller

Closed as the docker and docker-compose plugins have been removed from the project #2016

reubenmiller avatar Jun 09 '23 12:06 reubenmiller

Skipping test verification as it is more a refactoring topic and just removing code.

reubenmiller avatar Jun 09 '23 12:06 reubenmiller