thin-edge.io
thin-edge.io copied to clipboard
docker/docker-compos images are always pruned
Describe the bug
In the lifecycle of the docker plugin, the finalize step calls 'docker image prune --all --force' which would unconditionally remove all unused docker images whenever the docker plugin is asked to 'install/remove' something.
Expected behavior
ThinEdge should not remove things it was not asked about.
The same is true for the docker-compose plugin.
I agree that pruning all the images on install/remove is a cause of bad surprises.
I also wonder if this is the right place for these Docker and Docker Compose plugins. They are examples after all.
AC
- Fix the reported issue.
- Then move docker and docker-compose plugins to the example repo.
- Update tests using docker and docker-compose plugins from the example repo.
A new sm-plugin has already been created to support container management, see the tedge-container-plugin repository.
So all that is left is to remove the docker and docker-compose plugins from the project.
Closed as the docker
and docker-compose
plugins have been removed from the project #2016
Skipping test verification as it is more a refactoring topic and just removing code.