palworld-server-docker icon indicating copy to clipboard operation
palworld-server-docker copied to clipboard

fix: added basic yamls for kubernetes support.

Open beneiltis opened this issue 2 years ago • 2 comments

Just added support for kubernetes. We can use this as a starting point. I run it like this in my cluster and it works like a charm. Thx for the nice work @thijsvanloef

beneiltis avatar Jan 23 '24 09:01 beneiltis

@Slyke are you able to confirm that this fixes https://github.com/thijsvanloef/palworld-server-docker/issues/63?

thijsvanloef avatar Jan 23 '24 10:01 thijsvanloef

@Slyke are you able to confirm that this fixes #63?

Will check tonight after work.

Slyke avatar Jan 23 '24 11:01 Slyke

@thijsvanloef It seems to be working without my initContainer updating the permissions. Whether it's due to just needing a one time update or not is unknown. I would say that it's safe to merge though.

Slyke avatar Jan 24 '24 06:01 Slyke

Thx people :-) I have changed everything as requested. Realy good suggestions you guys made :-) much appreciated. I have checked it with my setup and it is still working great. Ready for merge :-)

beneiltis avatar Jan 24 '24 08:01 beneiltis

Have you thought about usage of kustomization, then you could roll it out with a single apply command.

elonmir avatar Jan 24 '24 08:01 elonmir

Just thinking out loud, maybe also adding a cronjob resource for backing stuff up? Out of scope?

elonmir avatar Jan 24 '24 08:01 elonmir

I would suggest we finish this PR and iterate from there on. Otherwise this is gonne be a never ending PR ;-)

beneiltis avatar Jan 24 '24 08:01 beneiltis

Nice work all 💪! @beneiltis should I wait before I merge this as @cdrage and @alex4108 are still pending reviewers, or are you confident?

thijsvanloef avatar Jan 24 '24 09:01 thijsvanloef

@thijsvanloef you can merge it from my point of view. I have modified all parts according to the guys suggestions. I also tried all manifests on my own server. everything works great.

beneiltis avatar Jan 24 '24 09:01 beneiltis

I would suggest we finish this PR and iterate from there on. Otherwise this is gonne be a never ending PR ;-)

Yes, sir! =) Good job anyways.

elonmir avatar Jan 24 '24 09:01 elonmir

Awesome, once again thank you for your work @beneiltis!

thijsvanloef avatar Jan 24 '24 09:01 thijsvanloef

Confirm it works my side too, awesome work @beneiltis :)

cdrage avatar Jan 24 '24 13:01 cdrage