palworld-server-docker icon indicating copy to clipboard operation
palworld-server-docker copied to clipboard

Add exponential backoff retry logic on initial connection

Open aarro opened this issue 1 year ago • 3 comments

Context

My environment lags a bit at getting a container connected to the internet. As a result, the check for connectivity to steam and install/update would fail. I've added an exponential_backoff function that will retry 5 times and applied it to the first connection check.

Choices

Seemed like the best solution.

Test instructions

I published it to dockerhub and installed pulled it into my environment with the lagging network. I then observed the now successful logs.

going to upload logs when I can again

Checklist before requesting a review

  • [x] I have performed a self-review/test of my code
  • [ ] n/a ~~I've added documentation about this change to the docs.~~
  • [x] I've not introduced breaking changes.
  • [x] My changes do not violate linting rules.

aarro avatar Jul 13 '24 20:07 aarro

Note: I'm using the prettier vs code extension (link) and it formatted the files I edited. It fixed some conflicting styles but also caused more than a few line changes. If preferred, I can remove those style changes and resubmit.

aarro avatar Jul 13 '24 20:07 aarro

@aarro Don't mind the style changes, but I believe that these are best to open a seperate PR for, keeps the purpose of this PR more clear.

thijsvanloef avatar Jul 15 '24 07:07 thijsvanloef

Is this still being worked on?

thijsvanloef avatar Aug 06 '24 15:08 thijsvanloef