palworld-server-docker icon indicating copy to clipboard operation
palworld-server-docker copied to clipboard

Published 20 hours ago • verified publisher icon thijsvanloef

Generate Engine.ini based on ENV vars

Open thijsvanloef opened this issue 1 year ago • 1 comments

Context

Fixes https://github.com/thijsvanloef/palworld-server-docker/issues/257 https://github.com/thijsvanloef/palworld-server-docker/issues/176 Enable users to generate the Engine.ini using evironment variabels

Choices

Using the same method as compile-settings.sh, compile the engine settings.

Test instructions

  1. Build the container
  2. set DISABLE_GENERATE_ENGINE to false
  3. check that ./palworld/Pal/Saved/Config/LinuxServer/engine.ini has been updated

Checklist before requesting a review

  • [x] I have performed a self-review of my code
  • [x] I've added documentation about this change to the docusaurus.
  • [x] I've not introduced breaking changes.

thijsvanloef avatar Feb 26 '24 14:02 thijsvanloef

Looks good to me. Tested it locally and it works without issues. It think it would be good to document in the docs how to enable it tho.

Also is there a specific reason why it is disabled by default?

Mostly because of backwards compatibility, I do not want to overwrite the changes someone has made already.

Documenting the need to enable is a good one, need to do that

thijsvanloef avatar Feb 26 '24 22:02 thijsvanloef