palworld-server-docker icon indicating copy to clipboard operation
palworld-server-docker copied to clipboard

Published 20 hours ago • verified publisher icon thijsvanloef

[FIX] fixed tips for docker compose & translations

Open lavi02 opened this issue 1 year ago • 3 comments

Context

  • Adjust the order of docker compose commands when backing up data with docker compose.
    • If follow the previous commands leads to initialization issues on Ubuntu 22.04 LTS version (AWS EC2).
  • Added missing Korean README translation

Choices

  • need to stop first before changing something.

Test instructions

Checklist before requesting a review

  • [v] I have performed a self-review of my code
  • [v ] I've added documentation about this change to the README.
  • [v] I've not introduced breaking changes.

lavi02 avatar Feb 05 '24 01:02 lavi02

It's better to include only one change in a single PR. If possible

I recommend submitting separate PRs for the translation and the modification of the Docker command.

DaeHyeoNi avatar Feb 05 '24 16:02 DaeHyeoNi

@DaeHyeoNi I agree on the splitting of PR's, however it's not really necessary for this one, since the change is so small

thijsvanloef avatar Feb 05 '24 18:02 thijsvanloef

Do I need to change something else? In the case of the last review, if I apply it, I think the actual content of the original document and the translated document seems to be slightly different.

lavi02 avatar Feb 05 '24 23:02 lavi02