palworld-server-docker icon indicating copy to clipboard operation
palworld-server-docker copied to clipboard

fix: swap image.name to image.repository

Open anthr76 opened this issue 1 year ago • 1 comments

Context

Swapping image.name to image.repository which tends to be more widely used in popular helm charts. This also has the added benefit of allowing it to work with the renovatebot

Choices

To be more in-line with popular helm charts and allow the renovatebot to manage dependencies.

Test instructions

Installing the helm chart

I'm not sure if automation will update the values markdown?

Checklist before requesting a review

  • [x] I have performed a self-review of my code
  • [ ] I've added documentation about this change to the README.
  • [ ] I've not introduced breaking changes. (Users will need to swap this in their values if they have it set)

anthr76 avatar Feb 01 '24 13:02 anthr76

@Filipe-Souza should I run helm-docs manually?

anthr76 avatar Feb 01 '24 13:02 anthr76

@anthr76 Is this PR ready to merge?

thijsvanloef avatar Feb 04 '24 11:02 thijsvanloef

@anthr76 I personally use git pre-commit hooks to update the docs, running manually is fine also.

Filipe-Souza avatar Feb 04 '24 18:02 Filipe-Souza

Sounds good! In that case this is ready to merge.

anthr76 avatar Feb 04 '24 18:02 anthr76