palworld-server-docker
palworld-server-docker copied to clipboard
thijsvanloef
Update start script
Updating to using array for STARTCOMMAND due to issues that su steam -c "${STARTCOMMAND}" can have with escaped quotes and spaces, also this will allow for spaces in server names and passwords
Context
Allow users to use spaces in environment variables
Choices
- Better handling of spaces in program arguments that should allow them, such as server name and passwords
Test instructions
- Run the server with this change and have spaces in the passwords or in the server name
Checklist before requesting a review
- [x] I have performed a self-review of my code
- [x] I've added documentation about this change to the README. there is no mention spaces aren't supported, so this will just be helpful overall
- [x] I've not introduced breaking changes. fully tested this time instead of just testing printing the startcmd. sorry about that! here's proof:
@Dashboy1998 looks like you were right about the [*] syntax vs. [@]. It looks to be honoring the spaces just fine, and the linter likes it better. Thanks again!
@thijsvanloef all set! Apologies for the delay. The only reason I've been able to focus on this and why I've been doing it in the middle of the night...I just had a baby girl! Our first one. Sorry to get personal, but I'm just too excited :D. It allows me a lot of time to play and mess around, but just when I want to do something that requires a reaction, of course there's something going on with baby 😆
@clarkent86 Wow! Congrats on the little girl! I wish you folks all the best. Ofcourse the baby comes first, don't worry about it! I don't have time to review this today, will definitely do so tomorrow!
