palworld-server-docker icon indicating copy to clipboard operation
palworld-server-docker copied to clipboard

Published 20 hours ago • verified publisher icon thijsvanloef

Added fix for blank PalWorld Settings file

Open Dashboy1998 opened this issue 1 year ago • 1 comments
trafficstars

Context

  • Removes the need to manually delete the PalWorldSettings.ini file if it is blank to trigger a copy of the default file at next startup.

Choices

  • Using grep since that is already included in the image.

Test instructions

  1. Start the container without :/palworld/Pal/Saved/Config/LinuxServer/PalWorldSettings.ini
  2. Verify the file is created
  3. Start the container with an empty (zero bytes, you can use touch) :/palworld/Pal/Saved/Config/LinuxServer/PalWorldSettings.ini
  4. Verify the file is overwritten
  5. Start container with a valid :/palworld/Pal/Saved/Config/LinuxServer/PalWorldSettings.ini (Ideally modify a value)
  6. Verify the file not overwritten

Checklist before requesting a review

  • [x] I have performed a self-review of my code
  • [x] I've added documentation about this change to the README.
  • [x] I've not introduced breaking changes.

Dashboy1998 avatar Jan 26 '24 19:01 Dashboy1998

I might have set shellcheck too strict, for now you can use:

# shellcheck disable=SC2143

In the line above the "faulty" line

thijsvanloef avatar Jan 26 '24 20:01 thijsvanloef