palworld-server-docker icon indicating copy to clipboard operation
palworld-server-docker copied to clipboard

Make volume mount hierarchy consistent, implement tickrate

Open hemsleyk opened this issue 1 year ago • 1 comments

Context

For me, volume mount was not updating despite destroying the pod and spawning a new one.

Changing the hierarchy to be consistent with the data dir mount fixed this when redeploying despite k8s claiming the yaml was equivalent.

My goal was to implement changes to the tickrate. This exposes tickrate as a setting.

Choices

Resolved my issue. Server subjectively seems more active.

Test instructions

kubectl exec -- cat /palworld/Pal/Saved/Config/LinuxServer/PalWorldSettings.ini

Before: default contents despite configmap looking correct

After: reflects custom configmap with tickrate change

Checklist before requesting a review

  • [✅] I have performed a self-review of my code
  • [✅] I've added documentation about this change to the README.
  • [✅] I've not introduced breaking changes.

hemsleyk avatar Jan 26 '24 19:01 hemsleyk

@hemsleyk Thanks for the PR, I do not have a kubernetes cluster so I marked it "help wanted" hopefully someone else is able to review!

thijsvanloef avatar Jan 26 '24 19:01 thijsvanloef

@hemsleyk Thanks for the PR, I do not have a kubernetes cluster so I marked it "help wanted" hopefully someone else is able to review!

The kubernetes side of these changes looks good to me

Twinki14 avatar Jan 27 '24 03:01 Twinki14

might not work because of how yaml is translating the spaces. Testing..

MSpreckels avatar Jan 27 '24 08:01 MSpreckels