palworld-server-docker
palworld-server-docker copied to clipboard
modify deployment and chart for opionated deployment
Context
It is relatively unsafe with the way Palworld handles it's server terminations to leave the default deployment setting of RollingUpdate. Switching to Recreate ensures the old pod is terminated and not writting to the volume while the new pod is starting.
Choices
Opionated change is done in the suggested deployment yaml and the chart sets Recreate by default but leave it a configurable option.
Test instructions
Deployed to my local cluster, valiadate that deployment still works and that it terminates the pod prior to scheduling the new pod.
Checklist before requesting a review
- [X] I have performed a self-review of my code
- [X] I've added documentation about this change to the README.
- [X] I've not introduced breaking changes.
Hi @Mercwri Thanks for taking the time to create this PR, i've marked it "help wanted" as I am currently not able to test it myself