palworld-server-docker icon indicating copy to clipboard operation
palworld-server-docker copied to clipboard

Published 20 hours ago • verified publisher icon thijsvanloef

Added description for server

Open Dashboy1998 opened this issue 1 year ago • 3 comments

Context

  • Add a description to the server

Choices

  • Implemented the same as the other settings

Test instructions

  1. Set a description in docker-compose
  2. Start container
  3. Join game
  4. Go to the options in game to see the description. For my testing I did Hello World. 20240125214337_1

Checklist before requesting a review

  • [x] I have performed a self-review of my code
  • [x] I've added documentation about this change to the README.
  • [x] I've not introduced breaking changes.

Dashboy1998 avatar Jan 26 '24 02:01 Dashboy1998

You should wait for https://github.com/thijsvanloef/palworld-server-docker/pull/124 to be merged, then update your changes to incorporate it. The current way does not support spaces in the server name and wouldn't in the description.

fryfrog avatar Jan 26 '24 05:01 fryfrog

You should wait for https://github.com/thijsvanloef/palworld-server-docker/pull/124 to be merged, then update your changes to incorporate it. The current way does not support spaces in the server name and wouldn't in the description.

I didn't have any issues with spaces in the server name or description as and that can be seen in the photo in the PR.

Dashboy1998 avatar Jan 26 '24 06:01 Dashboy1998

Needed to revert #124, your PR is still on my radar, but #124 has to be fixed first, sorry for the inconvenience.

thijsvanloef avatar Jan 26 '24 18:01 thijsvanloef

There was some fuckery going on with the revert, I believe I fixed it

thijsvanloef avatar Jan 27 '24 09:01 thijsvanloef