FontAwesome.swift icon indicating copy to clipboard operation
FontAwesome.swift copied to clipboard

Hello, macOS. πŸ‘‹

Open chriszielinski opened this issue 5 years ago β€’ 4 comments

It looks like a lot... & it is, but no preexisting code has been modified (aside from the occasional minimal refactoring). In general, I added macOS cross-platform compatibility, a macOS demo app + UI unit tests, & other unit tests.

You may notice that the UIKit-flavored objects do not get some of the new features like conformance to FontAwesomeRepresentable. This was entirely to avoid making any systemic modifications to the UIKit-platform code. Such features can easily be integrated into the UIKit-platform code at any point, should one want.

Comments, questions, or concerns?

chriszielinski avatar Feb 12 '20 03:02 chriszielinski

Hi Chris

I have an issue #249, from a problem I saw with Mac Catalyst (another approach to building a Mac App). Can you check if the unit test code that I included in my issue works with your changes. If it doesn't then I have a fix that doesn't rely on UIFont tracking font names

Cheers Derek

DerekK19 avatar Mar 24 '20 01:03 DerekK19

Hi Chris

I have an issue #249, from a problem I saw with Mac Catalyst (another approach to building a Mac App). Can you check if the unit test code that I included in my issue works with your changes. If it doesn't then I have a fix that doesn't rely on UIFont tracking font names

Cheers Derek

Got it πŸ‘! Good looks on the Mac Catalyst stuff though. Most of the AppKit goodies are purposefully left out, for now...

chriszielinski avatar Mar 29 '20 12:03 chriszielinski

Honestly this looks pretty good. I want to merge but there’s a few things on the iOS side I want to refactor first before we pull this in. Hang tight, I love this!

MatrixSenpai avatar Apr 26 '20 21:04 MatrixSenpai

Fantastic! I want to mention that integration with SPM seems to be broken with this. Integrated into a macOS project it still refers to UIKit related files.

bamx23 avatar May 08 '20 09:05 bamx23