gitlanding icon indicating copy to clipboard operation
gitlanding copied to clipboard

Published 20 hours ago • verified publisher icon thieryw

GlTemplate broken encapsulations

Open garronej opened this issue 2 years ago • 2 comments

Encapsulation is broken here

image

<GlImage /> should be in charge of reporting the aspect ratio upstream.

garronej avatar Apr 24 '22 01:04 garronej

https://github.com/thieryw/gitlanding/blob/b2c1ca5dbe9f9b99aeb9372e51db34094e023216/src/GlHero/GlHero.tsx#L136-L144

garronej avatar Apr 24 '22 01:04 garronej

I uderstand why it's conveignent to do it like that.
We should however use the className to select the component instead of requiring an id to be set. .

garronej avatar Apr 24 '22 01:04 garronej