Thierry Volpiatto

So no, this is not the reason, it is the repeated calls to locate-library which make things so slow, with this change, I get almost the same performances as before:...

So probably computing the path of the svg directory one time for all is the way to go.

So even if avoiding locate-library make things much faster, I still see some slowdowns due to stuff being computed at each of the function calls, probably these could be avoided...

Jimmy Yuen Ho Wong ***@***.***> writes: > 1. ( ) text/plain (*) text/html > > @thierryvolpiatto see if eb32540 works better. Yes, it is the same patch I used yesterday...

Jimmy Yuen Ho Wong ***@***.***> writes: > Let me know if you can think of other ways to speed up this branch :) I am now caching helm-imenu icons, it...

Jimmy Yuen Ho Wong ***@***.***> writes: > About cache, the icons are cached at here. Yes but this cover only: (all-the-icons-cache #'all-the-icons-icon-for-dir) (all-the-icons-cache #'all-the-icons-icon-for-dir-with-chevron) (all-the-icons-cache #'all-the-icons-icon-for-file) (all-the-icons-cache #'all-the-icons-icon-for-mode) (all-the-icons-cache #'all-the-icons-icon-for-weather)...

Jimmy Yuen Ho Wong ***@***.***> writes: > @thierryvolpiatto see if eb32540 works better. > > About cache, the icons are cached at here. Caching them at the icon set level...

For reference: https://github.com/emacs-helm/helm/commit/4a540f5cdda0fc1c26bdb0f4c84706108b7e6246

Now helm is working fine with this branch, by using caching where needed I have reduced memory usage and increased speed. When do you plan merging this branch to master?

Jimmy Yuen Ho Wong ***@***.***> writes: > Don't know, whenever I have some time and brain space :) Ok, looking forward for it :-). > Feel free to send over...