github-selfies icon indicating copy to clipboard operation
github-selfies copied to clipboard

GitHub enterprise support

Open ivey opened this issue 10 years ago • 5 comments

It would be great if I could add my GH:E URL to the matches. I don't know anything about Chrome Extensions, but I'm going to dig in and see if I can figure it out.

ivey avatar Mar 19 '14 16:03 ivey

you probably just need to edit these, but i don't know anything about github enterprise

stephenmathieson avatar Mar 19 '14 18:03 stephenmathieson

So, I can add an options page, but it won't be able to change the manifest, and will require using programmatic injection to selectively enable the extension at runtime on the page, and will require cross-domain permissions on every site.

Probably not worth it. I will keep poking though, and maybe I will find something.

ivey avatar Mar 19 '14 19:03 ivey

If you're able to add permissions to a site based on tags on the page both GH:E and standard Github have this tag set in their <head>:

<meta content="GitHub" property="og:site_name">

You could give it permissions for all sites and match on *://*/*/compare/* and do a check in the code to figure out if there's a /html/head/meta[property='og:site_name'] tag, but that feels a little nasty?

jphastings avatar Aug 21 '14 08:08 jphastings

Not sure if this is still being considered, but just in case, i'd like to add in a vote for GitHub enterprise support.

If it's helpful, this chrome extension seems to do a pretty decent job of supporting both github.com and enterprise options.

gtallen1187 avatar Feb 20 '16 00:02 gtallen1187

This extension also does github + enterprise https://github.com/thecodejunkie/github.expandinizr

tal avatar Jun 08 '17 16:06 tal