Thibault Charbonnier

Results 139 comments of Thibault Charbonnier

@agentzh Is this still in the picture? I'll start the work on `ngx.resolver` as well once I can focus on it. I still think this patch would be nice to...

1. Both an important security and usability fix, https://github.com/openresty/lua-nginx-module/pull/1600 should also be a part of this roadmap imho. Not only does the currently advertised way of using OpenResty leads to...

Here is my proposal: https://github.com/openresty/meta-lua-nginx-module/pull/76

Here is my alternative proposal to this feature: https://github.com/openresty/meta-lua-nginx-module/pull/76

@agentzh Tests usually refer to the Lua snippet within the `*_by_block` directive though, don't they? Are there other tests that rely on the `nginx.conf` line numbers themselves? This might be...

@agentzh Indeed, I have found the following cases of tests such as you described: ``` ./stream-lua-nginx-module/t/132-lua-blocks.t:qr/\[emerg\] .*? Lua code block missing the closing long bracket "]]" in .*?\bnginx\.conf:22/ ./stream-lua-nginx-module/t/132-lua-blocks.t:qr/\[emerg\] .*?...

@casimiro I'm looking at coverage which looks mostly good except for [this branch](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/530?src=pr&el=tree&filepath=src%2Fngx_wasmx.c#9bbb775399c0328cc56c6df3f220e8db-R1613) (open ngx_proxy_wasm_host.c file), I'm wondering how come it isn't covered, since I'm sure we have histogram tests...

I think I looked at everything now and the changeset looks all good. Once the last couple things are addressed I'll do a local merge with the minor stuff like...

@casimiro Before pushing to this branch again, could you rebase it on the latest main for the CodeQL changes, so that the code analysis integration doesn't get confused again (I...