iota.lib.cpp icon indicating copy to clipboard operation
iota.lib.cpp copied to clipboard

make wereAddressesSpentFrom protected

Open Cylix opened this issue 7 years ago • 0 comments

What is the purpose of your code change?

#312 iota.lib.js stopped exporting wereAddressesSpentFrom. As a consequence, I moved it to protected.

I checked, right now iota.lib.js still uses it for:

  • getNewAddress
  • getAccountData

On our library, we already use it for getNewAddress.

For getAccountData, this is not the case yet. From my understand, iota.lib.js returns an additional parameter inputs for which wereAddressesSpentFrom is used to determine which one are valid input or not.

Would also be consistent to use it in getInputs, which is planned for iota.lib.js but not done yet.

Will update this PR with the changes in getAccountData and getInputs (though, let me know if you have some feedback regarding that before I go forward with the implementation).

Resources links

iota.lib.js getAccountData iota.lib.js getNewAddress

Cylix avatar Sep 05 '18 06:09 Cylix