MessageBanner icon indicating copy to clipboard operation
MessageBanner copied to clipboard

Fixes initial frame issue

Open dtrotzjr opened this issue 10 years ago • 2 comments

The first time the Message Banner is shown it slides in from an arbitrary position at the top left. As far as I can tell this is due to the constraints being applied outside of the animation block.

Also setting currentMessageBanner.center = target is really not needed as this is using constraints which override setting the center anyway. I would drop setting currentMessageBanner.center = target as well as calculateTargetCenter: altogether except that there are side effects in calculateTargetCenter: which are needed.

dtrotzjr avatar Oct 25 '15 23:10 dtrotzjr

Thanks for the PR, il will merge a rework the center value during this weekend.

thibault-carpentier avatar Oct 28 '15 16:10 thibault-carpentier

Awesome! Thanks!

dctrotz avatar Oct 28 '15 17:10 dctrotz