puppet-sysctl icon indicating copy to clipboard operation
puppet-sysctl copied to clipboard
verified publisher icon thias

Support Puppet v4

Open ghoneycutt opened this issue 9 years ago • 6 comments

Modernize module

  • Drop support for Puppet v2.

  • Add support for Puppet v4.

  • Explicitly test against supported Ruby and Puppet matrix.

  • Support Ruby versions 1.8.7, 1.9.3, 2.0.0, 2.1.0 and 2.3.1.

  • Use puppet-lint v2.

  • Use community puppet-lint plugins (Code already complied with the style).

ghoneycutt avatar Nov 07 '16 20:11 ghoneycutt

Hi @thias could you please merge this

ghoneycutt avatar Nov 09 '16 15:11 ghoneycutt

Hello

Great job, I need this feature too :)

Regards

snahelou avatar Nov 29 '16 13:11 snahelou

Hej @thias, We are using a setup like @ghoneycutt proposed since years and it helps us a lot. It will create tests in all combinations of Puppet & Ruby, here is an example: https://travis-ci.org/Phil-Friderici/puppet-module-afs/builds/203724249

Please give it a try :)

Phil-Friderici avatar Feb 28 '17 14:02 Phil-Friderici

If you are interessted in this, I can add the needed changes to keep this running with the latest Puppets and gem versions.

Phil-Friderici avatar Apr 11 '17 09:04 Phil-Friderici

@Phil-Friderici I would be happy to accept those in my branch if you would like to submit a PR against that.

ghoneycutt avatar Apr 11 '17 20:04 ghoneycutt

@ghoneycutt sent a PR to your branch

@thias my repo has Travis CI enabled and you can have a peek how a PR will looks like with it [1] and what nice overview you get about the tested combinations of Puppet and Ruby [2].

[1] https://github.com/Phil-Friderici/puppet-sysctl/pull/1 [2] https://travis-ci.org/Phil-Friderici/puppet-sysctl/builds/221247268

Phil-Friderici avatar Apr 12 '17 07:04 Phil-Friderici