puppet-nagios
puppet-nagios copied to clipboard
thias
Puppetlabs apache dependency
Dear Thias,
I have been strugling to send you a set of pull requests, one for each important feature that I contributed, and it was impossible. Therefore, I am afraid I have to send all together into one single super-pull-request... sorry about that.
There are a few changes that are trivial, specially the first 5 commits (oldest). The next 5 commits correspond to the feature "remote checks", that is quite interesting to have other modules define their own checks, while leaving the nagios module alone. I would like to migrate all existing checks to this "new schema" some day soon. And the last commits are for another feature: puppetlabs-apache dependency. I put all your thias/apache dependencies into one big IF, and added a second big IF with the puppetlabs one. Hope you like it.
Have a good weekend!
BTW, I have updated the documentation and version number in my master branch... did not want to send you yet-another PR.
Ah... that! It was a pitty to change it, but the puppetlabs-apache module accepts the allow line as a string, not as an array, and I did not want to be special and go against the flow. Besides, all the code has this type of strings that should be arrays... I would like to improve it all, eventually, but today is not that day :) I don't want this to be a showstopper for our collaboration, so if you want me to change it back to array, I will.
Could you maybe change it back to an array, to not break the existing parameter values, and simply use the stdlib join() function to create the variable you need for the puppetlabs apache module?
It also seems there are references to apache_httpd as type rather than a class making the nagios::server code completely broken.
This is quite old and Thias has moved forward... I will merge with the newest and submit the PR again, but it will take me some time.
It also seems there are references to apache_httpd as type rather than a class making the nagios::server code completely broken.
You're probably using my apache_httpd module master branch from git, since the latest published forge version is still a definition. Adapting for the newer class is trivial, and will be done once I update my forge module to be a class.