puppet-bind
puppet-bind copied to clipboard
thias
Hard coded logging locations
Right now, logging appears not to be configurable, with the ERB file being hard-coded with the following stanzas:
logging {
channel main_log {
file "/var/log/named/named.log" versions 3 size 5m;
severity info;
print-time yes;
print-severity yes;
print-category yes;
};
category default{
main_log;
};
category lame-servers {
null;
};
};
It would be helpful if the contents of main_log could be altered, for example, to permit logs to be sent to syslog instead of a specific log file.
I raised a PR (#81) to address my immediate use case, but I recognise that a more flexible approach might be preferred.
@hybby my PR from awhile ago may be of interest/use: https://github.com/thias/puppet-bind/pull/57
@nickchappell - oh, excellent! This looks great. I'll close my PR, as it looks like you spent a bit more time on making things lovely and configurable. Thanks for sharing!
I hope that @thias has time to look at and merge your PR soon, as it would be a great contribution.
Please implement this. I'm afraid of the newrelic-forks version, as the commits are very old in this repo.
If logging is not configurable, could you consider at least not hardcoding the template ? This way it would be possible to specify the template to use as a parameter, without starting to make local commits to the module.
