puppet-bind icon indicating copy to clipboard operation
puppet-bind copied to clipboard

Published 20 hours ago • verified publisher icon thias

add support for keys

Open sethlyons opened this issue 10 years ago • 2 comments

i also fixed spec/classes/bind_server_spec.rb. it was expecting 'restart' => '/sbin/service named reload', but the manifest had service named reload. the test fix is in a separate commit.

sethlyons avatar Mar 11 '15 19:03 sethlyons

Thanks for this, but there are some minor issues with hashes. This is certainly one reason why in #54 an array was used : In ruby there is no guarantee for the order of a hash's keys, which is why there are these "sort_by" key everywhere. I'm not quite sure why you have added some, but removed others (views) and left some new ones out (keys values).

I'll go ahead and merge #54 for now. Are you still interested in rebasing your other changes? If not, I can re-implement them.

thias avatar Feb 02 '16 08:02 thias

hi! honestly, this was so long ago i don't remember. if you have a list of changes you want me to make, i'm happy to do it.

sethlyons avatar Feb 05 '16 13:02 sethlyons