octopus icon indicating copy to clipboard operation
octopus copied to clipboard

Published 20 hours ago • verified publisher icon thiagopradi

DB2 ibm_db gem support

Open calh opened this issue 5 years ago • 2 comments

This adds optional support for the ibm_db gem. If the ibm_db gem is not loaded in the bundle, octopus should behave the same as before. If the ibm_db gem is loaded, it enables some monkey patches in the ibm_db gem to work with Rails 4.2 and Rails 5.0.

This includes the Docker dev system commits in #526. Much of this PR is supporting code for the test suite and build system.

calh avatar Jul 18 '19 17:07 calh

@calh - any updates on this PR? would love to merge this changes.

thiagopradi avatar Sep 24 '19 03:09 thiagopradi

Hi @thiagopradi! I think this PR should be good to go. I'm actually using it right now in production. The only caveat, is that it requires some changes to the ibm_db gem. https://github.com/ibmdb/ruby-ibmdb/pulls/calh

IBM will most likely pull these in, but their release cycle is pretty slow. The good news, is that the ibm_db gem is set up to be completely optional in this PR. So, people that are not using DB2 will never see my code anyway.

I'll leave it up to you if you want to wait for a new ibm_db version, or merge this in.

Thanks for you time!

calh avatar Sep 25 '19 14:09 calh