octopus icon indicating copy to clipboard operation
octopus copied to clipboard

Support for connection URLs in shards.yml

Open hosh opened this issue 9 years ago • 6 comments

I noticed that the shards.yml parsing doesn't support connection URLs.

Are there plans for this in the future?

hosh avatar Sep 13 '15 09:09 hosh

It does, take a look here.

Feel free to reopen if there is a problem but it's probably a misconfiguration.

sobrinho avatar Oct 09 '15 14:10 sobrinho

I have a feeling that it doesn't work when used as part of a shard group. Works if you use individual shard names, but as soon as you nest it under a shard group things start failing.

Here's an example config that doesn't work:

octopus:
  environments:
    - development
  replicated: true
  fully_replicated: false
  default_migration_group: master
  development:
    read_replicas:
      <% ENV['DB_READ_REPLICA_URLS'].to_s.split(',').each_with_index do |read_replica, i| %>
      replica<%= i %>: <%= read_replica %>
      <% end %>

donaldpiret avatar Oct 14 '15 05:10 donaldpiret

What error do you see?

sobrinho avatar Oct 14 '15 11:10 sobrinho

I'm able to reproduce.

Seems like adding v = resolve_string_connection(v) to lib/octopus/proxy.rb:62 fix the problem, I will investigate latter today.

sobrinho avatar Oct 14 '15 12:10 sobrinho

@sobrinho did you get a chance to advance on this issue?

Keep Rocking!

fagiani avatar Oct 03 '16 15:10 fagiani

@fagiani we are no longer maintaining octopus, in fact, we should add an info about that in README, sorry :(

sobrinho avatar Oct 03 '16 20:10 sobrinho