IDMPhotoBrowser iPhone X support

iPhone X support

Open getaaron opened this issue 7 years ago • 5 comments

When presenting the IDMPhotoBrowser, the "Done" button is obscured by the sensor housing notch:

The top half of the "Done" button doesn't respond to touch events.

Oct 02 '17 00:10 getaaron

I just checked if the device is iphone X or not set the top inset of done button as shown below:

browser.doneButtonTopInset = 50.0f;

This will shift the done button little below.

Oct 03 '17 05:10 PrakashMaharjan

@PrakashMaharjan Right, but ideally the IDMPhotoBrowser would respect the safe insets property

Oct 03 '17 15:10 getaaron

I went with this for now…

if (@available(iOS 11.0, *)) {
    browser.doneButtonTopInset = MAX(browser.doneButtonTopInset, viewController.view.safeAreaInsets.top);
}

A more robust improvement that used the auto-layout constraints would be preferred.

Oct 29 '17 23:10 getaaron

Isn't this closed by https://github.com/thiagoperes/IDMPhotoBrowser/pull/282

Jun 18 '18 16:06 chris-hut

is this solved yet?

Jul 31 '18 09:07 SDGMazeGeek