Thiago Macieira

Results 85 comments of Thiago Macieira

I'd like to see changes logically grouped. For example, the first commit in the series says "tinycbor bug fixes". That does not belong with the rest. Please submit bug fixes...

Please see https://github.com/thiagomacieira/tinycbor/tree/dev for an initial API. Pay close attention to 86053d7c273da0f50f1db3b916a905f24f5eff89

@vrahane thanks for your attempt at rebasing, but you mustn't have done it right. Please look at your commit's change to cbor.h: it's removing a lot of code, the new...

You need to justify those changes: why do we need new headers? Let's schedule a call next week (can you send me an email reminding me?). I'd like to understand...

What I've done for strings is basically punt the problem. Both the "dup" and "copy" string functions require linear buffers. If your buffer isn't linear, then you must use the...

Yes, that would be helpful. Right now, I have a strawman only and more testing is required.

That's a very good question and that's where I'd like input. It is possible with the API as I wrote it, but it's ugly. Please note that this is more...

The consequences for the API: * `_cbor_value_get_string_chunk`: works. Whether the value stored in `bufferptr` is a pointer or something different depends on what the `transfer_string` callback does. * `_cbor_value_copy_string`: works...

No, you're correct. If it does not adjust the internal pointer, any TinyCBOR function that iterates over the string will fail. My Qt wrapper didn't call any such function, so...

I've also modified the writer function for the encoder to take an extra parameter, which will be different when appending the user's string. This should allow for encoding strings from...