typescript-rest icon indicating copy to clipboard operation
typescript-rest copied to clipboard

feat: alow getRoles to be async

Open lucasdidur opened this issue 5 years ago • 1 comments

To create a new Service Autenticator for firebase and get roles directly from database, getRoles functions need to be async

async getRoles(req: express.Request) {
    let user = await getRepository(User).findById(req.user as string);
    return [user.userType.toString()];
}

lucasdidur avatar Feb 26 '20 13:02 lucasdidur

Codecov Report

Merging #125 into master will increase coverage by <.01%. The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage   94.41%   94.41%   +<.01%     
==========================================
  Files          14       14              
  Lines        1128     1129       +1     
  Branches      204      204              
==========================================
+ Hits         1065     1066       +1     
  Misses         63       63
Impacted Files Coverage Δ
src/server/model/server-types.ts 100% <ø> (ø) :arrow_up:
src/authenticator/passport.ts 100% <100%> (ø) :arrow_up:
src/server/server-container.ts 87.86% <87.5%> (+0.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e3b45df...2fc5c42. Read the comment docs.

codecov[bot] avatar Feb 26 '20 13:02 codecov[bot]