ndarray icon indicating copy to clipboard operation
ndarray copied to clipboard

core.matrix integration?

Open mikera opened this issue 9 years ago • 3 comments

This looks like a cool library!

Any possibility to refactoring this to integrate with core.matrix? There's been some interest in a core.matrix for ClojureScript but the lack of a decent ndarray implementation has held it back.

As an extra upside thi.ng/ndarray would gain compatibility with the rest of the core.matrix ecosystem on the Clojure side. I'm thinking use with Incanter for visualisation etc.

I think the main work is: a) Port the core.matrix API and protocols to cljs / cljc b) Implement the core.matrix protocols for the thi.ng/ndarray classes

Thoughts?

mikera avatar Oct 09 '15 05:10 mikera

Hi Mike, I don't know about core.matrix enough to make this happen myself (and no current capacity to do so either), but if you want to take a stab, you're welcome to try it as long as it doesn't completely change the essence of how to use this lib.

postspectacular avatar Oct 09 '15 18:10 postspectacular

It wouldn't change your current API at all. People could use the core.matrix API but it would be an alternative, not a replacement.

It would add a core.matrix dependency (not particularly heavyweight)

If you are happy with that then I (or someone else on the team...) will take a look at a PR.

mikera avatar Oct 10 '15 01:10 mikera

Go for it then! :) Btw. this lib is already used as dependency for some of the visualization methods in thi.ng/geom (currently for heatmap & isolines, but soon more...)

postspectacular avatar Oct 10 '15 10:10 postspectacular