Thomas Grund

Results 40 comments of Thomas Grund

I migrated the compressor `Ndef` from here (https://github.com/alikthename/Musical-Design-in-Supercollider/blob/master/16_compression.sc) and integrated it in the SuperDirtMixer. I am really happy with this implementation. But maybe it's to complex to integrate it directly...

Sure, I will tackle this asap 🙂 I can create a separate MR and link this issue to it.

I started to migrate it - the problem was, that it didn't fully behaved like I expected it. But I have more knowledge about this and know how to proceed...

Hey everybody (@yaxu, @telephon), I was able to add the SuperDirtMixer compressor implementation to SuperDirt and adapted it a little bit. Feel free to have look. Here is the MR:...

> OK, maybe you can check this? I am eager to help :-) More details here: https://github.com/musikinformatik/SuperDirt/pull/307#issuecomment-2383967186 But we can continue the discussion in this PR.

Hey @telephon ! So in general the changes are doing what I expect. But there is one issue, that harte_echtzeit and me faced during our tests. It looks like, that...

@telephon can I help here to speed up this Pull Request? As in my [Pull Request](https://github.com/musikinformatik/SuperDirt/pull/307#issuecomment-2383967186), I would recommend to not execute `set` if the global effect is not active....

Hey @telephon thanks for letting me know :-) > The race condition happens when you are toggling the effects while you play notes from tidal, right? Exactly!

I finished my tests and I am a little bit confused now. The race condition still exists. I do not fully understand why this happens, but from the clients code...

Hey @telephon , I faced an issue with the changes you made in the `resume` function. To solve this, I changed it locally in this way: ``` resume { synth.server.sendBundle(nil,...