rollup-plugin-scss icon indicating copy to clipboard operation
rollup-plugin-scss copied to clipboard

Type of node-sass package

Open the-homeless-god opened this issue 4 years ago • 4 comments

Currently, node-sass has been marked as 'optional" dependency in package.json, but there are a few issues:

  • rollup-plugin-scss can't work without node-sass
  • project can't use installation like npm install --no-optional because rollup-plugin-scss will throws issues about missing of node-sass

Also some packages were deprecated

image

the-homeless-god avatar Dec 06 '20 02:12 the-homeless-god

  1. It can, using the sass package which does not require binaries
  2. Woops, the readme should be updated to indicate that node-sass should be installed specifically.

thgh avatar Dec 07 '20 11:12 thgh

I would suggest to not include node-sass as an optional dependency and always require to specify the preferred sass package in package.json.

Currently want to use the plugin with sass (dart-sass) but node-sass gets installed anyway.

sirikon avatar Dec 23 '20 16:12 sirikon

Let's do that for v3, PR welcome!

thgh avatar Jan 05 '21 08:01 thgh

Thanks for fixing this. This simple change sped-up our install time in a medium-size monorepo by 70%: https://github.com/3YOURMIND/kotti/pull/403

FlorianWendelborn avatar Apr 15 '21 15:04 FlorianWendelborn