Thomas Ghysels

Results 156 comments of Thomas Ghysels

Only compute computed properties when used in view: https://svelte.technology/repl?version=1.54.1&gist=4faf8a9862d75b3dec0b3a6079051643 Only compute computed properties when accessed: https://svelte.technology/repl?version=1.54.1&gist=7b93771bb5f0e9eadb99051df0158c2d Seems to work now, just a HMR bug? Only recompute computed properties which parameters...

Agree! I think it's because passport needs sessions so I added express-session which needs some storage.

It's lost in the oauth redirect indeed, should be easy to implement! PR welcome!

Not sure if it would work, but something like this could: ```ts buildConfig({ ..., plugins: [ oAuthPlugin({ mongoUrl: process.env.MONGO_URL, clientID: process.env.OAUTH_CLIENT_ID1, clientSecret: process.env.OAUTH_CLIENT_SECRET1, authorizationURL: process.env.OAUTH_SERVER1 + '/oauth/authorize1', tokenURL: process.env.OAUTH_SERVER1 +...

Feel free to reopen if it didn't work

Hmm, issue is probably related to the "name" of the strategy, `"oauth2"` [in this case](https://github.com/thgh/payload-plugin-oauth/blob/cbd8a02d99cd899623076a7055147ad1476ab430/src/index.ts#L252) `passport.use('anotherstrategy', strategy)` can be used to rename it over here: https://github.com/thgh/payload-plugin-oauth/blob/cbd8a02d99cd899623076a7055147ad1476ab430/src/index.ts#L188 PR welcome!

Thanks, best wishes to you! Did you also update line 188 and rebuild the plugin? Do you mind trying out `payload-plugin-oauth@next` ? * It assigns names to each strategy and...

`npm install payload-plugin-oauth@next` or `yarn add payload-plugin-oauth@next` (no need to update JS code, it will replace the existing plugin, you can always go back by installing npm install payload-plugin-oauth@latest) It's...

Still at the @next tag. Sounds like it's working, so will publish soon. You could make a pull request where userinfo function receives an object containing the accesstoken + refreshtoken....

Sounds related to these lines, what is your webpack config? https://github.com/thgh/payload-plugin-oauth/blob/d422f815127d90e3356b355bc22a41b45a4af0d5/src/index.ts#L209-L219