Giovanni Giacobbi comments

Results 30 comments of


                                            Giovanni Giacobbi

Add basic type narrowing in the loose equality with the empty string

> 1. Please fix the tests. I just pushed one round of fixes, I'll check the CI and in case fix it again. SIDE NOTE: It took me a moment...

Add basic type narrowing in the loose equality with the empty string

I finally managed to get tests to pass, please review the tests that I patched, especially 'bug-11674.php': I can't come up with any value that is false as `if ((string)...

Add basic type narrowing in the loose equality with the empty string

Oh that was a fast merge! I left some random comments while browsing through the code that didn't belong to this PR.. I was going to clean them up but.....

Add basic type narrowing in the loose equality with the empty string

Hmm I think the 2.0.x merge is not correct, I'm happy to fix it, should I send a PR?

Add basic type narrowing in the loose equality with the empty string

closes phpstan/phpstan#10338

imageclone fix leaks when tile and/or brush are set.

I believe this might cause some troubles if the cloned image brush/tile are later set to a new image. The only really clean solution I can think of is to...

Mistaken error 'If condition is always true.' with goto

Here is another example which leads to wrong "Unreachable statement" error: ```php function foo(int $a): string { if ($a > 0) goto next; return "positive"; next: return "negative"; } ```...

declare assert-if-true for filesystem functions

I had **no** idea that the assertion would actually assert the opposite if the condition is not met. This is very counter-intuitive for me.. I think the behavior with "="...

Fix extract signature

The param names should be the ones from php7. Reflection takes care of the correct names for 8.x.

Change return type of apcu_inc & apcu_dec function

I can confirm this change is correct in all apcu versions.