_arcade-organizer icon indicating copy to clipboard operation
_arcade-organizer copied to clipboard

Suggestion - Check & remove 'Arcade Organized/cores' if file / not a symlink

Open W00kums opened this issue 1 year ago • 0 comments

Scenario:

  • Simply copying/syncing a MiSTer setup to another storage device will break symlinks, turning them into regular files with the content being the path the link was originally directing to.

Issues:

  • Update will fail to create/update the symlink if '_Arcade Organized/cores' already exists as a file
  • Cleanup does not remove '_Arcade Organized/cores' (symlink or regular file), so the issue will still persist even after a cleanup

Suggestions:

  • On cleanup, remove '_Arcade Organized/cores' (mainly if not a link)
  • On update, check if '_Arcade Organized/cores' is a file (or not a link) and remove it prior to creating the symlink

For extra caution:

  • If '_Arcade Organized/cores' is determined to be a file, then it could be read/verified to contain the full path to '_Arcade/cores' prior to removal

I figure this is something that general MiSTer users could run into if they maintain multiple MiSTers or change/upgrade storage and a quick check/removal before generating the link would eliminate the issue.

Thanks for all you do for the community!!

W00kums avatar Jan 21 '24 20:01 W00kums