qr.flutter icon indicating copy to clipboard operation
qr.flutter copied to clipboard

Published 20 hours ago • verified publisher icon theyakka

Implemented some interesting user suggestions

Open alexanderkind opened this issue 1 year ago • 7 comments

Implemented some interesting user suggestions:

  1. Rounding data module and eye corners #192
  2. Rounding data module outside corners
  3. Background shape behind embedded image with rounding corners (EmbeddedImageShape)
  4. Adjusting the cutout of an embedded image #190
  5. Gradient for all (QrDataModuleShape, QrEyeShape, EmbeddedImageShape) #143

alexanderkind avatar Mar 16 '23 05:03 alexanderkind

thank you for addressing the review so quickly!

vanyasem avatar May 01 '23 12:05 vanyasem

wow very nice! thank you

razfazz avatar May 30 '23 13:05 razfazz

up

mminhlequang avatar Aug 16 '23 04:08 mminhlequang

up

2Math0 avatar Oct 12 '23 07:10 2Math0

@vanyasem What's preventing this from being merged? The proper image cutout alone makes the result look much more professional.

benjdero avatar Dec 14 '23 09:12 benjdero

@benjdero the fact that I am just a contributor, and not a project maintainer. I do not have write access to this repository, and thus I cannot merge this PR :) You need to contact the maintainers of this repo by email: [email protected]

vanyasem avatar Dec 14 '23 15:12 vanyasem

LGTM!!!

martipello avatar Dec 15 '23 13:12 martipello

@vanyasem why this update is still not merged?

Hilbert2048 avatar Apr 28 '24 17:04 Hilbert2048

@Hilbert2048 because I am just a random contributor, and not a maintainer of this project. I do not have write access to this repository, and thus I cannot merge this PR :) You need to contact the actual maintainers of this repo by email: [email protected]

vanyasem avatar Apr 28 '24 17:04 vanyasem

I think @lukef might have the write permission, would you please have a look at this pull request?

Hilbert2048 avatar Apr 28 '24 17:04 Hilbert2048