qr.flutter icon indicating copy to clipboard operation
qr.flutter copied to clipboard

Published 20 hours ago • verified publisher icon theyakka

#104: Fixed the padding

Open vanlooverenkoen opened this issue 2 years ago • 6 comments

Fixed #104

vanlooverenkoen avatar Aug 03 '21 08:08 vanlooverenkoen

@lukef any idea how we can get this merged?

vanlooverenkoen avatar Feb 23 '22 17:02 vanlooverenkoen

We are using this branch in production for over 7 months. Our app has 7 million installs. And we never had one complaint about a qr code that could not be scanned correctly. So I do think this can be merged and released

vanlooverenkoen avatar Feb 23 '22 18:02 vanlooverenkoen

Yep. This will be fixed in 5.0. I rewrote part of that code (for various reasons). Keeping this open as a reminder but you can check the (sometimes broken) work in progress on the wip-50 branch.

Heads up, 5.0 will break compatibility. Feedback welcome.

lukef avatar Mar 03 '22 15:03 lukef

Specific fixes are:

  1. no longer round the module size (your original change).
  2. disable antialiasing for square module styles when they're being drawn in a gapless context. This avoids the "ghost gap" that code was seeking to eliminate.

lukef avatar Mar 03 '22 17:03 lukef

Alright thanks already. We will migrate when this pull request in closed (meaning it is released)

vanlooverenkoen avatar Mar 04 '22 08:03 vanlooverenkoen

@lukef any progress

vanlooverenkoen avatar Feb 16 '23 18:02 vanlooverenkoen