KSP-X-Science icon indicating copy to clipboard operation
KSP-X-Science copied to clipboard

Published 20 hours ago • verified publisher icon thewebbooth

Fixes for KSP 1.5.0

Open Flupster opened this issue 7 years ago • 16 comments

Flupster avatar Oct 16 '18 17:10 Flupster

This is working nicely, thanks @Flupster

MateoCB avatar Oct 17 '18 01:10 MateoCB

compiled the mod with the modified files ,still doesn't work.

CptBoBy avatar Oct 18 '18 16:10 CptBoBy

I'll upload the compiled files later tonight and link them here, compiled fine for me and worked

Flupster avatar Oct 18 '18 17:10 Flupster

That would be awesome Flupster, thx alot mate!

DonCorleone-NL avatar Oct 18 '18 17:10 DonCorleone-NL

I'm not sure, but I think it doesn't work for some because of the changes to [x] Science!.csproj <HintPath>E:\SteamLibrary\steamapps\common\Kerbal Space Program\KSP_x64_Data\Managed\UnityEngine.dll</HintPath> from <HintPath>..\..\..\..\Games\KSP\KSP_Real\KSP_x64_Data\Managed\UnityEngine.dll</HintPath>.

new01DAY avatar Oct 18 '18 17:10 new01DAY

You need to add the references to the DLLs,mine was in another location,however I reverted it back in the second commit

Flupster avatar Oct 18 '18 17:10 Flupster

Yeah, sorry. I just realized why/what it was. I actually don't know much about compiling and I'm trying to figure it out.

new01DAY avatar Oct 18 '18 17:10 new01DAY

compiled without problems having set the proper references , but game still says incompatible and the x science window appears completely empty.

CptBoBy avatar Oct 18 '18 18:10 CptBoBy

zip of the compiled mod can be found in my fork releases over at https://github.com/Flupster/KSP-X-Science/releases/

Flupster avatar Oct 18 '18 19:10 Flupster

compiled without problems having set the proper references , but game still says incompatible and the x science window appears completely empty.

Just did a full reinstall of KSP dropped in the mod from my forks release page and works, i'm not sure why yours isn't working but you could try mine?

https://i.imgur.com/qSoSuF9.jpg

Flupster avatar Oct 18 '18 20:10 Flupster

compiled without problems having set the proper references , but game still says incompatible and the x science window appears completely empty.

Just did a full reinstall of KSP dropped in the mod from my forks release page and works, i'm not sure why yours isn't working but you could try mine?

https://i.imgur.com/qSoSuF9.jpg

tried with my old install , not even the empty science window appeared. completely reinstalled ksp ,and same thing ,at startup game says mod compatible only with 1.4.5 ,and game pretends mod is not even installed

CptBoBy avatar Oct 18 '18 20:10 CptBoBy

Thanks. But your 5.17.2 release zip that includes this change is broken - only 22 bytes.

My bad forgot to actually include in the mod within the zip, should be fixed now!

Flupster avatar Oct 19 '18 16:10 Flupster

FWIW I came here to submit a PR with more or less your exact changes, which work for me (with minor differences I'll comment on in the diff). Would suggest also updating CHANGES.md to keep the project consistent.

htadwilliams avatar Oct 20 '18 21:10 htadwilliams

This works on my machine. +1 vote for merge so it can go on CKAN

Tekaoh2 avatar Oct 22 '18 14:10 Tekaoh2

Updated for v1.6.0 of KSP, no actual changes were made just the version numbers, tested a little all seems to be working.

Flupster avatar Dec 22 '18 11:12 Flupster

Hey @Flupster, it seems there's no maintainers left here, maybe you could push it to CKAN as a new package ?

Or maybe a little ping to @thewebbooth could work ?

SilkDev avatar Jan 17 '19 14:01 SilkDev