worldcubeassociation.org icon indicating copy to clipboard operation
worldcubeassociation.org copied to clipboard

Competition form errors in "Name" are shown under "ID" field

Open dunkOnIT opened this issue 1 year ago • 4 comments

Should be a pretty easy change

image

image

dunkOnIT avatar Jun 14 '24 15:06 dunkOnIT

As you can see from the code comments, this is done intentionally for historical purposes. So if we change this, it will inadvertently trigger a "But previously this had always been done so-and-so, now it suddenly doesn't work as expected anymore" (where "expected" means "the way we became used to it") uproar.

Why did you file this ticket in the first place?

gregorbg avatar Jun 17 '24 10:06 gregorbg

Because it was reported in Discord and I don't read code comments as a matter of principle (read: it looked like a clear error and I was in a rush to capture it - Simon posted the code snippet in Discord, and I clearly missed the essential point of it!)

At the risk of asking... who will the uproar come from? And will it affect more than just where the error gets displayed?

dunkOnIT avatar Jun 17 '24 13:06 dunkOnIT

At the risk of asking... who will the uproar come from?

There's always somebody. Lost count of the number of times I thought "Surely no-one will notice" and then almost the entirety of all global WCA Delegates wanted to book plane tickets to Germany to personally lynch me.

gregorbg avatar Jun 17 '24 13:06 gregorbg

As you've seen, I'm all for taking user feedback seriously. But (if I'm understanding the situation correctly), it seems like we're keeping an unintuitive behaviour around because some users have gotten used to the unintuitive behaviour.

If my understanding is right, I strongly advocate for changing to the intuitive behaviour:

  1. New users not indoctrinated into our old ways are being inconvenienced by this
  2. The new competition form is an excellent opportunity to say "things are changing"
  3. The new behaviour would still be very clear on which field the errors are taking place in

If there is a niche-but-legitimate use case that some users rely on, I'm all for serving the user in that case. But this doesn't seem like such an instance (with my current understanding)

dunkOnIT avatar Jun 17 '24 14:06 dunkOnIT