worldcubeassociation.org
worldcubeassociation.org copied to clipboard
History competition order on persons page
Describe the bug Let's look at https://www.worldcubeassociation.org/persons/2022PHAN03?event=222 We can see that it LOOKS LIKE he broke the NR average with 1.06 in Sunway Velocity Mall Open 2024, and then broke it again with a 1.09 average in Singapore Mini 2024, which is confusing.
It can be much better, but NOT FIXED by adding Competitions.end_date DESC
after Competitions.start_date DESC
in https://github.com/thewca/worldcubeassociation.org/blob/5e96d14d63dab196eebffb283aa1fb0336ef37a4/app/controllers/persons_controller.rb#L36, which should make more cases correct.
I'm not quite sure if there's any more elegant way to resolve that so didn't make a PR, sorry about that.
To Reproduce Steps to reproduce the behavior: N/A
Desktop (please complete the following information): N/A
Smartphone (please complete the following information): N/A
Additional context