worldcubeassociation.org icon indicating copy to clipboard operation
worldcubeassociation.org copied to clipboard
verified publisher icon thewca

Allow qualification on the day of the deadline

Open gregorbg opened this issue 1 year ago • 1 comments

As per WRT remark. This PR merely swaps a < comparison for a <= comparison

gregorbg avatar May 24 '24 06:05 gregorbg

@gregorbg we may want to add test cases for on_or_before in addition to the before tests? Or just update the expectation of the old tests, I haven't looked in detail at which is more appropriate

dunkOnIT avatar May 24 '24 06:05 dunkOnIT

Isn't this V1?

FinnIckler avatar Dec 05 '24 14:12 FinnIckler

I believe v2 is just calling the qualification class to check qualifications, so it should still apply

dunkOnIT avatar Dec 05 '24 19:12 dunkOnIT

Can you also update the text on https://www.worldcubeassociation.org/competitions/WC2025#competition-events ? Under "Qualification" it says "by DATE_MINUS_ONE", and at the bottom it says "before".

Thank you!

timreyn avatar Dec 14 '24 01:12 timreyn