worldcubeassociation.org
worldcubeassociation.org copied to clipboard
thewca
Rewrite the new competitions overview table as actual <Table>
Instead of focusing on List Items that imitate the existing overview down to the precise CSS classes, I think a table (as in, an actual HTML table element) makes more sense. It gives us more potential to expand features, makes it easier to add columns, can possibly support sorting by clicking on the header row, etc...
- I feel like there should be a separate loading indicator per table.
- If it loads some competitions, then I play around with filters, I get a similar loading view as the original page load (above), except now the "v 0" tags are present. The inconsistency feels weird to me.
- The icon makes me think that clicking it will scroll me down. I think a more standard thing to do is "20+"?
- There seems to be a bug where selecting "All" events includes 333mbo and the other old events, so if I click "All" then start turning off individual events until they're all off, no competitions show up. Not related to this PR, though.
-
I was playing around with ordering (by announcement, then present, then recent) and got a crash to do with trying to
.mapsomething undefined. But I can't reproduce... -
I think the icons would look better if they were left-aligned.
Thanks for the extensive review including screenshots!
I've tried to address most of your concerns, the bugfix for the ".map something undefined" crash is just a vague guess though as long as there is no clear reconstruction
However, I'm not seeing any competitions on the map.
That's odd, I tried locally and the map works as expected (both on main and on this PR branch). So it might be a fluke?
Merging because this page is still in beta development state and changes won't be reflected on the main website for the average user (plus I basically got Kevin's okay on the code)