thewca
Added /competitions/:comp_id/qualifications route
Adds a route where competition qualification restrictions can be accessed directly, instead of needing to get them off the WCIF, for the Registration Service Backend to enforce qualification limits
Question: Should this be part of /competitions/:comp_id? I had opted not to add it there because that route is already returning a lot of data and needs to be reconsidered, so I don't want to make something else dependent on it.
It would certainly be easier to mock/handle in the Registration Service if it didn't require a second call to get qualification data, however, and most of the time it will just be an empty array
Question: Should this be part of
/competitions/:comp_id? I had opted not to add it there because that route is already returning a lot of data and needs to be reconsidered, so I don't want to make something else dependent on it.
The current /competitions/:comp_id endpoint is big and if you were to make it bigger, you'd be making other services that call this endpoint fetch more data than they expected, although the change is negligible. We should definitely think about a V1 API (graphql hint hint) but in my opinion, it should be fine to add this knowing we'd like to deprecate it at some point.
