worldcubeassociation.org icon indicating copy to clipboard operation
worldcubeassociation.org copied to clipboard

Migrate edit persons form to React with a modification

Open danieljames-dj opened this issue 1 year ago • 2 comments

Currently edit persons page (link to code) is written in html.erb and we have plans of improvements to the form. As a first step, it will be good if we have the page migrated to React.

Modification required:

  • "Incorrect WCA ID claim count" field is no longer needed, instead when we click 'fix' or 'update', the claim count should be set to 0.

danieljames-dj avatar Oct 02 '23 11:10 danieljames-dj

I actually already migrated the page, but got so wrapped up in the rest of the work I didn't make a PR. Do you want me to push it and you can take it over and finish it with the changes?

FinnIckler avatar Oct 02 '23 12:10 FinnIckler

Sure I can do that. Thanks Finn.

On Mon, Oct 2, 2023 at 16:39 FinnIckler @.***> wrote:

I actually already migrated the page, but got so wrapped up in the rest of the work I didn't make a PR. Do you want me to push it and you can take it over and finish it with the changes?

— Reply to this email directly, view it on GitHub https://github.com/thewca/worldcubeassociation.org/issues/8399#issuecomment-1742940850, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACISN6RTVAZ42GRXDKEDLCLX5KYZLAVCNFSM6AAAAAA5PIXQM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBSHE2DAOBVGA . You are receiving this because you authored the thread.Message ID: @.***>

danieljames-dj avatar Oct 02 '23 12:10 danieljames-dj