[Migrate React] Static Pages: Teams Committees

[revers3ntropy]

[revers3ntropy]

Interestingly, this fails on my machine on this test:

Capybara.using_wait_time(15) do
    # The 3D secure challenge is in a modal in an iframe in an iframe
    within_frame(page.find("body>div>iframe")) do
      within_frame(page.find("#challengeFrame")) do
        within_frame(page.find("iframe[name='acsFrame']")) do
          find(:button, id: button_id).click
        end
      end
    end
    expect(page).to have_text(message)
  end

Changing 15 to 60 makes it pass, but apparently works fine in CI, so I'm not sure if this is a problem?

[gregorbg]

This is the test that clicks through a Stripe payment process. Navigating the iFrames has been a pain in the a** for a long time, as long as CI passes on the second or third attempt it's fine.

[revers3ntropy]

Ah ok, thanks

[gregorbg]

Cool! Can I haz screenshots? :smile:

[revers3ntropy]

How's that? I definitely changed up the design a little but I think it is fairly reasonable...

[gregorbg]

How's that? I definitely changed up the design a little but I think it is fairly reasonable...

I love it! 😍 Two minor remarks:

1. I'm not too wild about the popup inside a popup when copying the mail address. See if there is some other design / mechanism that you can use. (Completely random thought: Have the mail icon "roll open" on mouseover, i.e. just enlarge it horizontally so that the mail address can fit next to the envelope icon whenever you move the mouse there)
2. The black frame around the Board profile pictures might be interpreted as "this person passed away" depending on the culture. Could you either consider another color (there's no law or WCA Motion mandating these frames to be black) or another design instead of the frame?

[revers3ntropy]

I've got the email address to expand on hover now and only use one popup (absolute pain, ended up using css transitions after trying to do it with Semantic UI).

I only copied the colours around the different roles from the current UI. Personally I feel that all the colours in the user badges detract from the design and just make it feel more cluttered, but I can see why you might want to highlight certain people. I'm especially happy to treat the board members as normal team members in the UI, as I think if colours are used it should be to highlight members in teams not an entire team.

[gregorbg]

Please rebase to resolve the conflicts, and then we're good to merge!

[gregorbg]

It still says "This branch cannot be rebased due to conflicts". If you can hit the button on your end, please go ahead. Otherwise, please make sure to rebase cleanly.

[revers3ntropy]

Yep I should be able to, I'll just also tweak the background colours...

Thanks so much for the review, I know you're very busy at the moment.

[DanielEgdal]

Quick note, it seems like many avatars are displayed poorly because the regular user defined thumbnail isn't used, but rather some custom crop/minimisation.

[revers3ntropy]

I can't see what you mean... Screenshots maybe?

[DanielEgdal]

Look at the difference in zoom and centering of WRC. Of course some people don't have the same picture anymore, but focus on the ones that do (Antonio, Han, Oliver, Patrick as examples) Staging: WCA now

[revers3ntropy]

Ah yes I do see what you mean. It appears that the thumbnail should be ..._thumb.jpeg, thanks for noticing that!

[EdHollingdale]

Not sure if this was a desired design change, but it looks like the colours on badges on individual profiles have gone. Personally speaking, the orange on grey is pretty hard to read.

[gregorbg]

@revers3ntropy I may have been a bit premature with merging your recent CSS fixes PR. Please investigate the issue described by Edward because it still persists even after your recent round of fixes (and is definitely not intended!)

[Randomno]

Senior members are not being ordered correctly (i.e. they should be listed after the team Leader)

[revers3ntropy]

Interesting... This isn't happening for me on prod 😅 What is your environment?

[Randomno]

I'm using the website on Firefox. Works on Edge.

[revers3ntropy]

Great thanks, I'll look into it :)