thewca
Implement a posting results "check-in"
The WRT has a bunch of new members, and the risk of two (or more) members posting results at the same time has increased. The current workflow is to send a "posting" email in the results thread, but it's definitely error prone and may or may not reflect what's being done on the website depending on the mail clients/internet.
The idea behind this PR is to introduce some kind of "posting results" index, which would list the competition pending posting from a WRT members, let WRT member declare they are posting one or more competitions (aka "taking the lock"), let other members visiting the page know that someone is posting (and who).
As far as the WRT is concerned I think this contains just what we need, but I'll let other members chime in if needed.
Screenshot of a list of competitions needing posting:
This is the view when taking the lock on one competitions:
It sends a mail in the results email thread of that competition:
This is the same view but from another WRT member:
Clicking "post the competition" on the competition admin page clear the lock for that competition, and it looks like this:
It's worth noting that the person posting one competition can add more competitions to those currently being posted (since we can post multiple competitions at the same time), however the form would be totally disabled if another member is posting at least one competition.
If nothing more urgent requires it, do you think it would be possible to deploy these changes to staging so that the WRT can take a look at how it looks "in real time"?
Almost forgot, it's accessible from a "posting dashboard" entry in the admin panel:
Awesome work!
One quick question: If I decide that I cannot post results after checking the box next to a competition, would I be able to uncheck the box to release the lock?
Is the following possible? For releasing the lock: Change it from the button on the dashboard "Post Results" to Competition Page > Edit > Admin View > "Post the Results" Button? Clicking the actual post results button would release the lock for that competition.
One quick question: If I decide that I cannot post results after checking the box next to a competition, would I be able to uncheck the box to release the lock?
No, since checking-in/locking sends a mail I figured it would be weird having multiple mails; it wouldn't be too much trouble to allow the user to unlock it though (and it's worth noting that regardless of the state displayed on the page, you can always do any admin task you want, including uploading any result).
Is the following possible? For releasing the lock: Change it from the button on the dashboard "Post Results" to Competition Page > Edit > Admin View > "Post the Results" Button? Clicking the actual post results button would release the lock for that competition.
I think the behavior you want is already implemented: the "post the results" button on this new page links to the php posting page for that competition! The rationale is that I wanted to provide the two useful links present in the result submission email we receive. The lock for that competition is indeed release when clicking the "post results" button on the competition admin page (see here).
What's the current status on this? Are there any open "procedural" questions that need to be clarified among WRT? Or is this just pending a code review from us?
Technically it's a pending code review, but I'd love to give it a shot on staging so that WRT members can play with it a bit; would you be able to arrange that please?
As far as the actual code is concerned, even if some feedback requires changes, I don't think it should move that much, and it would be awesome to get a first batch of reviews.
Was this played with on staging? I don't remember any discussion
It was briefly active but with all the recent re-deploys it definitely isn't on staging anymore.
Potentially dumb question, but: With the PHP migration done, do you even need this feature anymore?
Ha nice coincidence, I just pushed a rebased version of this PR!
Yes I think it would be a nice addition, especially given @danieljames-dj has some improvements idea for it! Removing php did let us post in parallel, but we still "synchronize" through a slack channel to make sure a competition is posted by a single WRT member. We also still don't have a nice page displaying all the competitions which need to be posted (I personally just keep unposted competitions in my mail inbox and archive the thread when it's done). I believe this PR provides a very basic but efficient dashboard to know what's being done/need to be done :)
The screenshots are still accurate, I just changed the "Post the results" button to "Import the results" to match the route/page name.