worldcubeassociation.org icon indicating copy to clipboard operation
worldcubeassociation.org copied to clipboard

Trainee Delegates on Staff Mailing List

Open Epride opened this issue 3 years ago • 3 comments

Describe the bug Trainee Delegates currently receive communications sent to the WCA Staff Mailing list

Expected behavior As Trainee Delegates are not staff they should not receive these. They should only be receiving reports

Epride avatar May 17 '22 11:05 Epride

staff@ is a "meta-list" that we do not directly sync members to. Instead, it forwards to several lists like software@, results@, board@, etc.. that we actually do sync members to.

In this instance, the error occurs because we sync Trainee Delegates to [email protected] which in turn is part of staff@. Are Trainees supposed to be part of delegates@? If yes, this is a flaw in the way we conceptually designed the staff@ setup and not an actual website bug :innocent:

gregorbg avatar May 17 '22 13:05 gregorbg

Kindly ping @Epride

gregorbg avatar Jun 10 '22 08:06 gregorbg

Following up this issue; has the discussion gone any further?

Nevseros avatar Oct 10 '22 07:10 Nevseros

Should delegates@wca perhaps be split into delegates@wca for all Junior and above, and trainees@wca for trainees only? Then delegate reports can be sent to both groups, and only delegates@wca is part of staff@wca.

To my mind that seems like a pretty simple way of implementing this - but my Google Admin knowledge is limited.

dunkOnIT avatar Oct 20 '22 05:10 dunkOnIT

Apologies for my silence here but the suggestion by @dunkOnIT seems like a fairly reasonable way forward

Epride avatar Nov 01 '22 10:11 Epride

Techincal note to people who wish to implement this: You need to touch WcaOnRails/app/jobs/sync_mailing_lists_job.rb where currently it syncs User.delegates to the delegates@ list. Create an additional staff_delegates scope that includes only Delegates (DB column delegate_status NOT NULL) that are not trainee_delegate in the DB (how to do this is left as an exercise).

Then add a second line to the sync job referring to trainees@wca to sync the existing User.trainee_delegates scope to. I have created an empty mailing list that can automatically be found and used by our Ruby code without any additional setup.

gregorbg avatar Nov 05 '22 10:11 gregorbg

Fixed in #7395

gregorbg avatar Dec 18 '22 03:12 gregorbg