wca-live icon indicating copy to clipboard operation
wca-live copied to clipboard

Quitting a competitor suggests wrong replacement when their prior results changed

Open julesDesjardin opened this issue 7 months ago • 1 comments

Hi,

When fixing a scoretaking mistake after a competition, I changed the R1 results of a competitor, and then cleared their results and quit them from R2 because they no longer qualified for the round.

Instead of giving me the correct competitor as a replacement, WCA Live gave me the competitor behind the unqualified competitor with their new result.

To be more clear, here is the affected round. Romain Stefan was initially qualified, but then wasn't anymore. I cleared his result, and quit him, and it suggested Samuel Jehanno, when it should have suggested Gabin Thiery. (Based on a later test on a local instance of Live, clicking "yes" would have indeed accepted Samuel instead of Gabin).

Based on the same local test, updating that competitor's results to a full DNF doesn't suggest a competitor to replace them with, because there is noone else with results after them now.

This feels like a pretty important bug, because as far as I know, this popup is the only way to accept new people into subsequent rounds, and it could be easily missed, and qualify the wrong competitor after a scoretaking mistake. My example isn't an issue because the competition is already over anyway, but it can also happen during a competition if the next round is opened before scorechecking is done.

Steps to reproduce:

  1. Enter some results in a first round.
  2. Open the second round.
  3. Change the result of a qualified competitor in the first round so that they don't qualify anymore.
  4. Quit them from the second round.

julesDesjardin avatar Jul 07 '24 13:07 julesDesjardin