instantgram icon indicating copy to clipboard operation
instantgram copied to clipboard

bug: Videos outside of modals

Open mklaber opened this issue 2 years ago • 3 comments

instantgram no longer works for videos on individual pages (they still work in stories and when the video is displayed in a modal/carousel).

  • Example of a single vid post that doesn't work
  • Example of a multi media post that opens the photo instead of the active video

(Note: I'm working on a fix but opening this issue to track the work)

mklaber avatar Sep 10 '22 10:09 mklaber

The underlying issue is that videos no longer have the loop attribute. I've attempted to get at the current video using the same carousel code as the multiple images code. Problem is that the video, once found, doesn't have the fallbackSrc attribute. I can find a videoUrl by going up several parents of the video, but it finds a video URL that is different from the modal video. It might be the same quality (not super sure) but being a different vid makes it hard to know if one has already saved said video. So... less than ideal.

Have you any ideas, @theus ?

mklaber avatar Sep 10 '22 13:09 mklaber

I'm wondering if v5.0.3 fixed that 🤔

theus avatar Oct 24 '22 18:10 theus

@theus - thank you so much for 5.0.3 ! Seems it's working perfectly so far (5.0.2 was mostly broken since Instagram converted videos to blob URLs).

Is there a repo where we can see the original JavaScript code? (this repo only seems to have the compiled/unreadable code)

Others could probably contribute by investigating/fixing things sooner, if we could see the original code and submit Pull Requests with fixes 😊

Thank you again!

ghnp5 avatar Oct 25 '22 03:10 ghnp5