python-tuf icon indicating copy to clipboard operation
python-tuf copied to clipboard
verified publisher icon theupdateframework

Enable linters

Open jku opened this issue 1 year ago • 2 comments

Enable linters:

  • flake8-unused-arguments
  • flake8-executable
  • pygrep-hooks
  • flake8-pie
  • flake8-pyi
  • flake8-raise
  • flake8-self

These were all low hanging fruit where ruff can autofix or where there were only a few issues to fix.

This is part of #2567

jku avatar Apr 03 '24 12:04 jku

Pull Request Test Coverage Report for Build 8964888708

Details

  • 16 of 16 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.588%
Totals Coverage Status
Change from base Build 8936891421: 0.0%
Covered Lines: 1462
Relevant Lines: 1487
💛 - Coveralls

coveralls avatar Apr 03 '24 12:04 coveralls

closing/reopening to trigger tests again

jku avatar Apr 22 '24 12:04 jku

rebased on main again

jku avatar May 06 '24 06:05 jku

These feel mostly nit picky. But I also won't argue with an auto-formatter. 😅

yeah some of the rules are very arguable... but for each ruleset there's typically a bunch of really good ones that just fit our code 100% so I figured the few weird ones we can live with or disable individually

jku avatar May 07 '24 09:05 jku